-
Notifications
You must be signed in to change notification settings - Fork 108
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Added Discrete Cosine Transform and Tests #480
Conversation
Alright, very good start :) I see you fail the flake8 test. Please run pre-commit on your codes before commiting/pushing as explained here https://pylops.readthedocs.io/en/latest/installation.html#install-pre-commit-hooks Also, i reccomend to look at https://pylops.readthedocs.io/en/stable/api/generated/pylops.signalprocessing.DWT.html#pylops.signalprocessing.DWT as a guideline when you write the docstring (especially the Notes section), right now it’s a bit rough Apart from these minor issue, the PR looks very good :) I’ll start and review and give you details comments on the code itself |
Alright, great! Can you please also reply to each of the comments above so it’s easier for us to check that you have implemented the suggested changes. Also please add the example in the meantime so we can have everything in one PR 😀 |
Great work! I left a few more comments. Once you have taken those into account and added the example, we should be ready to go :) |
@dikwickley I went through your PR and made some minor changes trying to improve its consistency with the rest of Pylops's codebase. I suggest we wait until @cako takes a look as well, after that it is perhaps better if you make a brand new PR making sure you start from the latest dev (right now for example your doc conf.py file is not the latest one - old documentation). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Excellent PR. Most of the changes are relatively cosmetic, with the exception of no touching .pre-commit-config.yaml. But they should all be very straighforward. Thanks!
Added the DCT operator.
Example is yet to be added.
issue: #46