Skip to content

Commit

Permalink
removed TODOs in source files
Browse files Browse the repository at this point in the history
  • Loading branch information
Uwe Hernandez Acosta committed Oct 7, 2024
1 parent b230698 commit 952f113
Show file tree
Hide file tree
Showing 4 changed files with 3 additions and 17 deletions.
9 changes: 1 addition & 8 deletions src/lorentz_boost/boost_parameter/boost_axis/types.jl
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@

# TODO:
# - test conversions
# - decompose into separate files

"""
AbstractAxisBoostParameter{T}
Expand All @@ -19,9 +14,7 @@ This abstract type is meant to be extended by concrete types to represent boosts
"""
abstract type AbstractAxisBoostParameter{T} <: AbstractBoostParameter end

function (::Type{BP})(
boost_val::Real
) where {T<:Real,BP<:AbstractAxisBoostParameter{T}}
function (::Type{BP})(boost_val::Real) where {T<:Real,BP<:AbstractAxisBoostParameter{T}}
return BP(T(boost_val))
end

Expand Down
5 changes: 0 additions & 5 deletions src/lorentz_boost/boost_parameter/boost_vector/types.jl
Original file line number Diff line number Diff line change
@@ -1,8 +1,3 @@
# TODO:
# - add interaction with axis boosts
# - add convenient constructors BetaVector(p) for the rest system?
# - test constructor error

"""
AbstractBoostVector <: AbstractBoostParameter
Expand Down
4 changes: 0 additions & 4 deletions src/lorentz_boost/types.jl
Original file line number Diff line number Diff line change
Expand Up @@ -85,10 +85,6 @@ Base.eltype(boost::Boost) = eltype(boost.param)
Boost(x::Real) = Boost(BetaX(x))
Boost(x::Real, y::Real, z::Real) = Boost(BetaVector(x, y, z))

# TODO:
# - add more convenient functions (type of the boost_param, ... )
# - interaction between several boosts? -> product trafo (for later)

function _transform(boost::Boost, p::AbstractFourMomentum)
return _transform(boost.param, p)
end
Expand Down
2 changes: 2 additions & 0 deletions src/patch_QEDbase.jl
Original file line number Diff line number Diff line change
@@ -1,3 +1,5 @@
# This can be removed, if https://github.com/QEDjl-project/QEDbase.jl/pull/129 is merged
# and released.

#######
# General coordinate transformations
Expand Down

0 comments on commit 952f113

Please sign in to comment.