-
Notifications
You must be signed in to change notification settings - Fork 3
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
This is dangerous and we should instead find the actual reason for the inconsistency. I'll leave this as a draft for now and will look into it more later. Since `Base.@assume_effects` requires Julia 1.8 this will fail unit tests anyways. Having these functions infer `:consistent` correctly by the compiler can significantly help with optimization in the compiler, so eventually we should try to make sure that most of QEDcore functionality has as many effects inferred as possible. Edit: I have removed the assumptions again because they are not safe to make (at least not for all element types). We should come back to this at a later point. For now, I have only added some `@inbounds` statements.
- Loading branch information
1 parent
81d1025
commit d89144f
Showing
1 changed file
with
14 additions
and
12 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters