Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Revoke namespace change #29

Merged
merged 4 commits into from
Jun 27, 2024

Conversation

AntonReinhard
Copy link
Member

This PR revokes the namespace changes done before QEDbase.jl 0.2 was released.

Currently based on #25, I will rebase once that is merged.

@AntonReinhard
Copy link
Member Author

I've also deleted the ProcessSetup tests since fixing them started taking too long and they are deprecated anyways.

@AntonReinhard AntonReinhard marked this pull request as draft June 26, 2024 09:38
docs/Project.toml Outdated Show resolved Hide resolved
@AntonReinhard AntonReinhard force-pushed the revoke_namespace_change branch from 63693ed to e100971 Compare June 26, 2024 10:00
@AntonReinhard AntonReinhard marked this pull request as ready for review June 26, 2024 10:02
@AntonReinhard
Copy link
Member Author

General question since we will now often implement interfaces defined somewhere else (i.e. in QEDbase): I think for clarity it would be a good idea to always use function QEDbase.interface_function() ... end directly, because it makes it clear right there that it's implementing an interface. The other option is having an import QEDbase: interface_function at the start of the file. This, in my opinion, kind of hides the fact that when we have function interface_function() ... end later, it is implementing an interface from QEDbase.

I've done it using QEDbase.interface_function mostly, but not everywhere. If we want to make that a guideline I will go through this pr again and do it in the remaining places.

Thoughts?

@AntonReinhard AntonReinhard marked this pull request as draft June 26, 2024 10:05
@szabo137
Copy link
Member

General question since we will now often implement interfaces defined somewhere else (i.e. in QEDbase): I think for clarity it would be a good idea to always use function QEDbase.interface_function() ... end directly, because it makes it clear right there that it's implementing an interface. The other option is having an import QEDbase: interface_function at the start of the file. This, in my opinion, kind of hides the fact that when we have function interface_function() ... end later, it is implementing an interface from QEDbase.

I've done it using QEDbase.interface_function mostly, but not everywhere. If we want to make that a guideline I will go through this pr again and do it in the remaining places.

Thoughts?

As I mentioned somewhere else, I think QEDbase.interface_function is favorable, because of the reasons you already mentioned. Therefore, I agree with making this the guideline.

@szabo137
Copy link
Member

@AntonReinhard is there a reason, that this is still a draft?

@AntonReinhard
Copy link
Member Author

@AntonReinhard is there a reason, that this is still a draft?

Yes, as I mentioned I will go through again and remove the import QEDbase: ... occurrences. Then I'll mark it ready.

@AntonReinhard AntonReinhard marked this pull request as ready for review June 27, 2024 11:05
Copy link
Member

@szabo137 szabo137 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LTFM.

@szabo137 szabo137 merged commit 56f2444 into QEDjl-project:dev Jun 27, 2024
2 checks passed
@AntonReinhard AntonReinhard deleted the revoke_namespace_change branch June 27, 2024 14:22
@AntonReinhard AntonReinhard added this to the Release 0.1.0 milestone Aug 9, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants