Add convenience constructors for particle statefuls #33
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
As a note: I added the functions to QEDcore instead of in QEDbase on the |
|
Integration test for QEDprocesses fails because QEDprocesses relies on QEDjl-project/QEDbase.jl#87 which is not released yet. |
Is it related to this issue? QEDjl-project/QuantumElectrodynamics.jl#36 |
This was referenced Jul 8, 2024
Closed
|
@szabo137 ping |
szabo137
approved these changes
Jul 12, 2024
szabo137
approved these changes
Jul 13, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds convenience constructors which are helpful when juggling the types around and wanting to construct a
ParticleStatefulfrom them. IfTis a fully specializedParticleStateful{DIR, SPECIES, ELTYPE}, before you would have had to extract theDIRandSPECIESto call the constructor, now you can simply doT(mom).