Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Release 0.1.0 #38

Merged
merged 2 commits into from
Jul 15, 2024
Merged

Release 0.1.0 #38

merged 2 commits into from
Jul 15, 2024

Conversation

szabo137
Copy link
Member

Add changes from release branch 0.1.0 back to dev.

don't forget: no squishing

@szabo137 szabo137 requested a review from AntonReinhard July 13, 2024 21:29
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

👍

@AntonReinhard
Copy link
Member

I can't merge this because my approval doesn't count since I'm the last pusher...

@szabo137
Copy link
Member Author

Me neither, because I am the creator of this 🤷‍♂️
@SimeonEhrig @steindev would some of you be so kind and hit the approve button.

IMPORTANT: in the case of merging, please do not squash the commits. This would destroy the sync of main and dev, which causes some trouble for the next release.

@SimeonEhrig
Copy link
Member

@szabo137 Which merge should I do? Create a merge commit or rebase and merge?

@SimeonEhrig SimeonEhrig merged commit 44683f0 into dev Jul 15, 2024
4 checks passed
@szabo137
Copy link
Member Author

@szabo137 Which merge should I do? Create a merge commit or rebase and merge?

@SimeonEhrig best is create a merge commit, thanks 🙏

@AntonReinhard AntonReinhard deleted the release-0.1.0 branch November 5, 2024 10:09
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants