Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removed ParticleSpinors #61

Merged
merged 4 commits into from
Oct 8, 2024

Conversation

szabo137
Copy link
Member

As the title indicates, this removes particle spinors, because it's redundant. The function base_state provides the same functionality, but uses AbstractSpins instead of integer indices.

The unit tests are updated accordingly, i.e. the properties of fermion states (normalization, Dirac's equation, sandwich product) are checked using base_state(::FermionLike,::ParticleDirection,::SFourMomentum, ::AbstractSpin).

AntonReinhard
AntonReinhard previously approved these changes Sep 14, 2024
Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good to me.
I especially appreciate the deletion of the trailing whitespaces :)
I just have some minor nitpicking

test/particles/states.jl Outdated Show resolved Hide resolved
test/particles/states.jl Outdated Show resolved Hide resolved
Co-authored-by: Anton Reinhard <anton.reinhard@proton.me>
@szabo137 szabo137 merged commit 1e93eed into QEDjl-project:dev Oct 8, 2024
4 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants