Remove base patch #71
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
I think the unit test template was actually wrong, since it did not use dev version dependencies. I fixed this by taking the template from QEDprocesses.jl. Generally, I think we should stop allowing |
AntonReinhard
force-pushed
the
remove-base-patch
branch
from
d0278a5 to
9ad5d0e
Compare
1 task
|
@szabo137 Can you please review it. It is block the QEDbase 0.3 release. |
SimeonEhrig
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Merge after #69
This deletes the QEDbase patch which is no longer necessary as the relevant PR in QEDbase was merged.
Unfortunately, there seems to be a somewhat strange interaction of doubly defined typenames and
@reexport, creating an issue in QEDbase's documentation building. This means that I had to remove some@extrefstatements for now that can be readded later, when QEDbase is ready.