Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix: particle implementations from core #27

Merged
merged 2 commits into from
Jun 21, 2024

Conversation

szabo137
Copy link
Member

Take particles from QEDcore, not from QEDbase.

@szabo137 szabo137 requested a review from AntonReinhard June 21, 2024 06:40
@szabo137
Copy link
Member Author

szabo137 commented Jun 21, 2024

@AntonReinhard works! 🙆‍♂️

Edit: this was tested locally against QEDjl-project/QEDbase.jl#68 and passed the unit tests.

Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

@AntonReinhard AntonReinhard merged commit b0d80d0 into QEDjl-project:dev Jun 21, 2024
4 checks passed
@AntonReinhard AntonReinhard added this to the Release-0.1.0 milestone Aug 6, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants