Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

SetupDevEnv.jl: Check for QED package version and set it in the compat section of other packages #79

Merged
merged 2 commits into from
Oct 28, 2024

Conversation

SimeonEhrig
Copy link
Member

@SimeonEhrig SimeonEhrig commented Oct 24, 2024

If a QED package has increased its version, all other QED packages will continue to work in the CI tests, even if they have not yet updated their compat section.

…t section of other packages

If a QED package has increased its version, all other QED packages will continue to work in the CI tests, even if they have not yet updated their compat section.
@SimeonEhrig SimeonEhrig marked this pull request as ready for review October 28, 2024 16:17
@SimeonEhrig
Copy link
Member Author

Because this PR blocks our CI, I skipped some refactoring work. Therefore the code in the utils.jl copied from the SetupDevEnv.jl.

Copy link
Member

@AntonReinhard AntonReinhard left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I suggest opening an issue for the remaining refactoring work, other than that this looks good to me 👍

@SimeonEhrig
Copy link
Member Author

I suggest opening an issue for the remaining refactoring work, other than that this looks good to me 👍

Done in #82

@SimeonEhrig SimeonEhrig merged commit 6316403 into QEDjl-project:dev Oct 28, 2024
3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants