[ENH] Preprocess image widget #7
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
preprocessimage
branch
from
10f717c to
f369ff5
Compare
markotoplak
force-pushed
the
preprocessimage
branch
from
f369ff5 to
4a4187c
Compare
The biggest problem is that settings for image previews are still context settings, and that is a problem because the matching them precisely should not be required. Now if user switches the data set to a one that has different column names, preprocessors are going to be forgotten. Because the actual preprocessing is more important than the previews, the settings here should not be context settings, or should be at least made optional.
markotoplak
force-pushed
the
preprocessimage
branch
from
4a4187c to
16fb68e
Compare
markotoplak
force-pushed
the
preprocessimage
branch
from
22dda55 to
4217149
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This adds Preprocess Image widgets, which is functionally the same as Preprocess Spectra, but has Images for previews.
This addition is very incomplete, but the architecture for adding individual preprocessors is there. I made a small example preprocessor and editor.
Known issues:
This partially implements #8. It is in a state that allows preprocessor development and testing.
I'll fix the above issues some other time.
Using this requires the master branch of Spectroscopy (and this is why tests fail).