Test #618
Draft
Test #618
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
markotoplak
force-pushed
the
test
branch
7 times, most recently
from
81f20cb to
17b86fa
Compare
markotoplak
force-pushed
the
test
branch
3 times, most recently
from
6df5b74 to
c779d77
Compare
- Code cleanup - Faster data preparation - Improved handling of inputs with different features
…nputs to using table names
Fixup: wpolar: Fixed auto selection of angle separator,
This is just a column selection and is fast, so there is no need to perform it in a separate thread. Also, if users now select different vector features, the image data is not recomputed.
Potentially fixes an issue which persisted where contexts would be loaded when variables did not exist in the domain
Prevents updating data in the widget while tasks are being run. sharedmemory blocks were previously being erased, leaving processes with no data
NB: Test does not fail, but ValueError does appear in output
Some lists are edited in place, therefore copy them before sending them into the computation thread.
Codecov Report
@@ Coverage Diff @@
## master #618 +/- ##
==========================================
- Coverage 89.27% 88.67% -0.61%
==========================================
Files 71 72 +1
Lines 11759 12483 +724
==========================================
+ Hits 10498 11069 +571
- Misses 1261 1414 +153 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I do not understand why #615 tests fail (do not find the correct file), so trying to retest in a new PR.