-
Notifications
You must be signed in to change notification settings - Fork 16
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Improve DeepLinking by accessing the stored value of @Published properties directly #7
Open
pauljohanneskraft
wants to merge
1
commit into
main
Choose a base branch
from
deeplink
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file was deleted.
Oops, something went wrong.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,47 @@ | ||
// | ||
// DeepLinkableWrapper.swift | ||
// XUI | ||
// | ||
// Created by Paul Kraft on 01.03.21. | ||
// Copyright © 2021 QuickBird Studios. All rights reserved. | ||
// | ||
|
||
public protocol DeepLinkableWrapper { | ||
var content: Any { get } | ||
} | ||
|
||
extension Published: DeepLinkableWrapper { | ||
|
||
public var content: Any { | ||
guard let value = Mirror(reflecting: self).descendant("storage", "value") else { | ||
assertionFailure("We could not extract a wrappedValue from a Published property wrapper.") | ||
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. Who's "we"? 😅 |
||
return () | ||
} | ||
return value | ||
} | ||
|
||
} | ||
|
||
extension Binding: DeepLinkableWrapper { | ||
public var content: Any { wrappedValue } | ||
} | ||
|
||
extension State: DeepLinkableWrapper { | ||
public var content: Any { wrappedValue } | ||
} | ||
|
||
extension ObservedObject: DeepLinkableWrapper { | ||
public var content: Any { wrappedValue } | ||
} | ||
|
||
extension EnvironmentObject: DeepLinkableWrapper { | ||
public var content: Any { wrappedValue } | ||
} | ||
|
||
extension Store: DeepLinkableWrapper { | ||
public var content: Any { wrappedValue } | ||
} | ||
|
||
extension Optional: DeepLinkableWrapper { | ||
public var content: Any { flatMap { $0 } ?? () } | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,28 @@ | ||
|
||
import XCTest | ||
@testable import XUI | ||
|
||
class ParentViewModel: ViewModel, ObservableObject { | ||
@Published var child: ChildViewModel? | ||
} | ||
|
||
class ChildViewModel: ViewModel, ObservableObject { | ||
|
||
} | ||
|
||
final class DeepLinkTests: XCTestCase { | ||
|
||
func testMirror() { | ||
let viewModel = ParentViewModel() | ||
XCTAssertNil(viewModel.firstReceiver(as: ChildViewModel.self)) | ||
viewModel.child = .init() | ||
XCTAssertNotNil(viewModel.firstReceiver(as: ChildViewModel.self)) | ||
viewModel.child = nil | ||
XCTAssertNil(viewModel.firstReceiver(as: ChildViewModel.self)) | ||
} | ||
|
||
static var allTests = [ | ||
("testMirror", testMirror), | ||
] | ||
|
||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Let's rename the
compactMap
closure as it's not a compact map, it's the function that is applied by compact map (but not only!).Suggestion:
mappingFunction
ortransform
.(I know this code was just moved, but I only noticed it now.)
Also, this is a good example where more code is easier to read:
This makes it much more visible when recursion occurs and which is the recursion anchor.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
(Also not sure about the function name
values
but I see where it comes from and I don't have a better idea right now.)