Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: turn exhortignore strategy into sensitive #66

Merged
merged 2 commits into from
Oct 17, 2023

Conversation

zvigrinberg
Copy link
Collaborator

Description

Change the logic of exhortignore feature in sbom creation for maven package manager to be sensitive ( was insensitive), that is , only delete exhortignored artifacts from sbom' components and dependencies lists, but not their transitive ( their transitive will remain as components, whether they're transitive of other non exhortignored direct artifacts or not (as orphaned components)).

Related issue (if any): fixes #issue_number_goes_here

Checklist

  • I have followed this repository's contributing guidelines.
  • I will adhere to the project's code of conduct.

Additional information

exhortignore

Anything else?

Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
@github-actions
Copy link

github-actions bot commented Oct 16, 2023

Test Results

75 tests   75 ✔️  56s ⏱️
  7 suites    0 💤
  7 files      0

Results for commit d4510cc.

♻️ This comment has been updated with latest results.

Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
@zvigrinberg zvigrinberg enabled auto-merge (squash) October 17, 2023 09:34
@zvigrinberg zvigrinberg disabled auto-merge October 17, 2023 09:35
@zvigrinberg zvigrinberg merged commit 0acf1eb into main Oct 17, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant