-
Notifications
You must be signed in to change notification settings - Fork 7
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: results of pip show are not properly parsed #70
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Example package information that cannot be parsed correctly by splitting by
|
xieshenzh
force-pushed
the
fix-python-dep
branch
from
October 18, 2023 20:50
ee60826
to
2b45f7e
Compare
xieshenzh
force-pushed
the
fix-python-dep
branch
from
October 19, 2023 13:27
2b45f7e
to
3827d2c
Compare
zvigrinberg
approved these changes
Oct 23, 2023
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@xieshenzh good catch!
lgtm, Approved.
You can merge whenever you want
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Splitting
pip show
results with---
could generate incorrect results when a package contains license information.An example of such package can be generated by executing
pip3 show scipy
.Code in this PR reads the results of
pip show
line by line, and groups information by packages.Jira: https://issues.redhat.com/browse/TC-644
Checklist
Additional information