fix: maven - error parsing artifact with classifier #78
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
unable to parse an artifact that contains classifier ( version suffix) Jira Ticket: https://issues.redhat.com/browse/TC-766 Signed-off-by: Zvi Grinberg <zgrinber@redhat.com>
zvigrinberg
force-pushed
the
hotfix/fix-maven-parse-with-classifier
branch
from
fdf9072 to
bb173f5
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
When there is in dependency tree an artifact with classifier, the components are in different positions( the version) in the string, and there are 6 parts instead of 5 parts, so need to identify it , and parse it correctly.
For example:
5 parts ( no classifier):
com.google.guava:guava:jar:10.0.1:compile
6 parts ( with classifier):
org.sonatype.sisu:sisu-guice:jar:no_aop:3.1.0:compile
Fixes: https://issues.redhat.com/browse/TC-766
Checklist