Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Assorted deploy fixes + tweaks #178

Merged
merged 3 commits into from
Jan 25, 2024
Merged

Assorted deploy fixes + tweaks #178

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2f02fdc
Update NVMRC version
bcspragu Jan 25, 2024
462dbcd
Build dev before lint + typecheck
bcspragu Jan 25, 2024
d4476e7
Fix loading issue
bcspragu Jan 25, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion .github/workflows/deploy.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -45,9 +45,9 @@ jobs:
working-directory: frontend
run: |
npm ci
npm run build:dev
npm run lint
npm run typecheck
npm run build:dev

- name: Run all builds and tests
run: |
Expand Down
2 changes: 1 addition & 1 deletion .nvmrc
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1 +1 @@
16.13
18.18
5 changes: 2 additions & 3 deletions frontend/composables/useModal.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,7 +41,7 @@ export const useModal = () => {
loadingSet.value.add(loadKey)
}
const stopLoading = (loadKey: string) => {
return () => loadingSet.value.delete(loadKey)
loadingSet.value.delete(loadKey)
}
const clearLoading = () => { loadingSet.value.clear() }
const withLoading = <T> (fn: () => Promise<T>, opKey: string): Promise<T> => {
Expand All @@ -64,7 +64,7 @@ export const useModal = () => {
startLoading(opKey)
onMounted(() => {
fn()
stopLoading(opKey)()
stopLoading(opKey)
})
}

Expand Down Expand Up @@ -97,7 +97,6 @@ export const useModal = () => {
withLoading,
onMountedWithLoading,
startLoading,
stopLoading,
clearLoading,
loading,
loadingSet,
Expand Down
Loading