Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix hipExtModuleLaunchKernel function #3111

Merged
merged 6 commits into from
May 28, 2024

Conversation

slojosic-amd
Copy link
Collaborator

hipExtModuleLaunchKernel function name should not be mangled in case of cross-platform compilation. Mangled hipExtModuleLaunchKernel function name causes linking issues with migraphx_gpu.dll on Windows.
image

@slojosic-amd slojosic-amd requested a review from causten as a code owner May 22, 2024 15:37
Copy link

codecov bot commented May 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.82%. Comparing base (263509b) to head (655ee37).
Report is 149 commits behind head on develop.

Additional details and impacted files
@@           Coverage Diff            @@
##           develop    #3111   +/-   ##
========================================
  Coverage    91.82%   91.82%           
========================================
  Files          486      486           
  Lines        18993    18993           
========================================
  Hits         17440    17440           
  Misses        1553     1553           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented May 22, 2024

Test Batch Rate new
e67d2c
Rate old
bceef1
Diff Compare
torchvision-resnet50 64 1,712.17 1,712.95 -0.05%
torchvision-resnet50_fp16 64 3,568.32 3,811.61 -6.38% 🔴
torchvision-densenet121 32 1,381.72 1,458.96 -5.29% 🔴
torchvision-densenet121_fp16 32 2,068.57 2,432.65 -14.97% 🔴
torchvision-inceptionv3 32 879.44 883.89 -0.50%
torchvision-inceptionv3_fp16 32 1,365.54 1,381.08 -1.13%
cadene-inceptionv4 16 375.89 408.06 -7.88% 🔴
cadene-resnext64x4 16 413.77 413.67 0.03%
slim-mobilenet 64 3,820.30 3,824.46 -0.11%
slim-nasnetalarge 64 96.65 97.02 -0.37%
slim-resnet50v2 64 1,651.23 1,651.41 -0.01%
bert-mrpc-onnx 8 590.19 589.10 0.19%
bert-mrpc-tf 1 284.83 288.10 -1.14%
pytorch-examples-wlang-gru 1 301.54 300.11 0.48%
pytorch-examples-wlang-lstm 1 309.82 265.42 16.73% 🔆
torchvision-resnet50_1 1 436.32 437.05 -0.17%
cadene-dpn92_1 1 231.66 243.98 -5.05% 🔴
cadene-resnext101_1 1 189.00 189.16 -0.08%
onnx-taau-downsample 1 203.89 204.02 -0.06%
dlrm-criteoterabyte 1 22.24 22.24 0.02%
dlrm-criteoterabyte_fp16 1 40.64 41.43 -1.92%
agentmodel 1 6,034.49 6,319.63 -4.51% 🔴
unet_fp16 2 32.30 33.77 -4.34% 🔴
resnet50v1_fp16 1 530.63 549.27 -3.39% 🔴
resnet50v1_int8 1 455.30 456.03 -0.16%
bert_base_cased_fp16 64 618.15 620.67 -0.41%
bert_large_uncased_fp16 32 178.92 193.76 -7.66% 🔴
bert_large_fp16 1 103.92 103.76 0.15%
distilgpt2_fp16 16 1,163.90 1,186.96 -1.94%
yolov5s 1 294.36 298.20 -1.29%
tinyllama 1 22.28 23.32 -4.47% 🔴
vicuna-fastchat 1 128.26 133.50 -3.92% 🔴
whisper-tiny-encoder 1 236.69 240.87 -1.74%
whisper-tiny-decoder 1 246.29 245.38 0.37%

This build is not recommended to merge 🔴

@migraphx-bot
Copy link
Collaborator

migraphx-bot commented May 22, 2024


     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output


     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance

@apwojcik apwojcik added Windows Related changes for Windows Environments bugfix Fixes a bug found in the code. labels May 22, 2024
@apwojcik apwojcik added the UAI label May 27, 2024
@causten
Copy link
Collaborator

causten commented May 28, 2024

FYI you don't need to merge develop multiple times in a row.

@causten causten merged commit 1f8619e into develop May 28, 2024
18 of 19 checks passed
@causten causten deleted the fix_hipExtModuleLaunchKenrel_func_export branch May 28, 2024 22:55
lajagapp pushed a commit to lajagapp/AMDMIGraphX that referenced this pull request Jul 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bugfix Fixes a bug found in the code. UAI Windows Related changes for Windows Environments
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants