-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add unpack_int4 kernel #3528
Add unpack_int4 kernel #3528
Conversation
music-dino
commented
Oct 15, 2024
- Implement JIT kernel for unpack_int4
- Remove unpack_int4 CPU offloading for GPU target
- Remove cpu offloading for unpack_int4 in gpu lowering - Fix clang tidy issue
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3528 +/- ##
========================================
Coverage 92.17% 92.17%
========================================
Files 512 512
Lines 21387 21391 +4
========================================
+ Hits 19714 19718 +4
Misses 1673 1673 ☔ View full report in Codecov by Sentry. |
src/targets/gpu/kernels/include/migraphx/kernels/unpack_int4.hpp
Outdated
Show resolved
Hide resolved
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Left a couple of minor comments. Approved.
Check results before merge 🔆 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |