-
Notifications
You must be signed in to change notification settings - Fork 89
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Disable dot/mul optimizations when there is int4 weights #3645
Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## develop #3645 +/- ##
========================================
Coverage 92.18% 92.18%
========================================
Files 513 513
Lines 21576 21596 +20
========================================
+ Hits 19889 19908 +19
- Misses 1687 1688 +1 ☔ View full report in Codecov by Sentry. 🚨 Try these New Features:
|
if(contains({"reshape", "dequantizelinear"}, alias->name())) | ||
return self(alias->inputs().front()); | ||
if(alias->name() == "concat") | ||
return all_of(alias->inputs(), self); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be any_of
? Also, the name of this function/lambda from_int4
should say any
or all
, just to make its intent clear. Thanks.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Shouldn't this be any_of?
No, if its mixed then we cant get int4 out of it.
This build is not recommended to merge 🔴 |
🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output |
No description provided.