Use and keyword consistently

[pfultz2]

Also, enable clang tidy to check for this.

[TedThemistokleous]

Add in lowering.cpp as well

[TedThemistokleous]

Rekicking CI this looks good and its good we're integrating this into CI, should add consistency

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 92.29%. Comparing base (976ae75) to head (18a9e04).
Report is 5 commits behind head on develop.

Additional details and impacted files

@@             Coverage Diff             @@
##           develop    #3676      +/-   ##
===========================================
+ Coverage    92.28%   92.29%   +0.01%     
===========================================
  Files          519      519              
  Lines        22222    22217       -5     
===========================================
- Hits         20507    20505       -2     
+ Misses        1715     1712       -3     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

[migraphx-bot]

Test	Batch	Rate new 18a9e0	Rate old 43488c	Diff	Compare
torchvision-resnet50	64	3,252.15	3,254.25	-0.06%	✅
torchvision-resnet50_fp16	64	6,922.94	6,916.65	0.09%	✅
torchvision-densenet121	32	2,453.86	2,455.95	-0.09%	✅
torchvision-densenet121_fp16	32	4,159.92	4,183.26	-0.56%	✅
torchvision-inceptionv3	32	1,630.11	1,629.97	0.01%	✅
torchvision-inceptionv3_fp16	32	2,714.21	2,715.98	-0.07%	✅
cadene-inceptionv4	16	762.79	762.93	-0.02%	✅
cadene-resnext64x4	16	813.02	812.98	0.01%	✅
slim-mobilenet	64	7,459.99	7,459.33	0.01%	✅
slim-nasnetalarge	64	208.62	208.65	-0.01%	✅
slim-resnet50v2	64	3,444.66	3,445.08	-0.01%	✅
bert-mrpc-onnx	8	1,147.36	1,147.48	-0.01%	✅
bert-mrpc-tf	1	481.73	481.97	-0.05%	✅
pytorch-examples-wlang-gru	1	480.28	478.37	0.40%	✅
pytorch-examples-wlang-lstm	1	433.44	439.41	-1.36%	✅
torchvision-resnet50_1	1	801.50	803.28	-0.22%	✅
cadene-dpn92_1	1	425.75	427.49	-0.41%	✅
cadene-resnext101_1	1	385.49	376.23	2.46%	✅
onnx-taau-downsample	1	372.38	373.50	-0.30%	✅
dlrm-criteoterabyte	1	33.31	33.31	-0.00%	✅
dlrm-criteoterabyte_fp16	1	52.61	52.64	-0.05%	✅
agentmodel	1	8,570.60	8,546.35	0.28%	✅
unet_fp16	2	58.41	58.43	-0.03%	✅
resnet50v1_fp16	1	1,053.13	1,033.48	1.90%	✅
resnet50v1_int8	1	1,016.88	1,018.13	-0.12%	✅
bert_base_cased_fp16	64	1,181.28	1,181.00	0.02%	✅
bert_large_uncased_fp16	32	365.15	365.36	-0.06%	✅
bert_large_fp16	1	198.92	201.35	-1.21%	✅
distilgpt2_fp16	16	2,227.03	2,228.65	-0.07%	✅
yolov5s	1	529.30	527.51	0.34%	✅
tinyllama	1	43.85	43.62	0.53%	✅
vicuna-fastchat	1	176.15	173.15	1.74%	✅
whisper-tiny-encoder	1	416.63	416.80	-0.04%	✅
whisper-tiny-decoder	1	430.50	429.87	0.15%	✅

This build is OK for merge ✅

[migraphx-bot]

     ✅ bert-mrpc-onnx: PASSED: MIGraphX meets tolerance

     ✅ bert-mrpc-tf: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-gru: PASSED: MIGraphX meets tolerance

     ✅ pytorch-examples-wlang-lstm: PASSED: MIGraphX meets tolerance

     ✅ torchvision-resnet50_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-dpn92_1: PASSED: MIGraphX meets tolerance

     ✅ cadene-resnext101_1: PASSED: MIGraphX meets tolerance

     ✅ dlrm-criteoterabyte: PASSED: MIGraphX meets tolerance

     ✅ agentmodel: PASSED: MIGraphX meets tolerance

     ✅ unet: PASSED: MIGraphX meets tolerance

     ✅ resnet50v1: PASSED: MIGraphX meets tolerance

     ✅ bert_base_cased_fp16: PASSED: MIGraphX meets tolerance

🔴bert_large_uncased_fp16: FAILED: MIGraphX is not within tolerance - check verbose output

     ✅ bert_large: PASSED: MIGraphX meets tolerance

     ✅ yolov5s: PASSED: MIGraphX meets tolerance

     ✅ tinyllama: PASSED: MIGraphX meets tolerance

     ✅ vicuna-fastchat: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-encoder: PASSED: MIGraphX meets tolerance

     ✅ whisper-tiny-decoder: PASSED: MIGraphX meets tolerance

     ✅ distilgpt2_fp16: PASSED: MIGraphX meets tolerance