[Experimental] PPU LLVM: Recycle identical functions #15308
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
elad335
added
Optimization
|
Who wants to test MGS4 compilation time and link time (Applying PPU code)? |
Megamouse
reviewed
Mar 11, 2024
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -3845,6 +3850,154 @@ extern void ppu_precompile(std::vector<std::string>& dir_queue, std::vector<ppu_ | |||
| } | |||
| } | |||
| } | |||
|
|
|||
| if (file_queue.size() > old_size && file_queue.size() - 1 > old_size) | |||
There was a problem hiding this comment.
Suggested change
| if (file_queue.size() > old_size && file_queue.size() - 1 > old_size) | |
| if (file_queue.size() > old_size + 1) |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
Comment on lines
3876
to
3889
| for (auto& [name, key] : s_ch_to_lang) | ||
| { | ||
| if (key == g_cfg.sys.language) | ||
| { | ||
| chosen_lang = name; | ||
| break; | ||
| } | ||
| } | ||
|
|
||
| if (g_cfg.sys.language == CELL_SYSUTIL_LANG_ENGLISH_GB) | ||
| { | ||
| // Fallback | ||
| chosen_lang = "us"sv; | ||
| } |
There was a problem hiding this comment.
Suggested change
| for (auto& [name, key] : s_ch_to_lang) | |
| { | |
| if (key == g_cfg.sys.language) | |
| { | |
| chosen_lang = name; | |
| break; | |
| } | |
| } | |
| if (g_cfg.sys.language == CELL_SYSUTIL_LANG_ENGLISH_GB) | |
| { | |
| // Fallback | |
| chosen_lang = "us"sv; | |
| } | |
| const s32 language = g_cfg.sys.language == CELL_SYSUTIL_LANG_ENGLISH_GB ? CELL_SYSUTIL_LANG_ENGLISH_US : g_cfg.sys.language; | |
| for (auto& [name, key] : s_ch_to_lang) | |
| { | |
| if (key == language) | |
| { | |
| chosen_lang = name; | |
| break; | |
| } | |
| } |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
|
|
||
| if (chosen_lang.empty()) | ||
| { | ||
| // Disable optimization if other langues are selected |
There was a problem hiding this comment.
Suggested change
| // Disable optimization if other langues are selected | |
| // Disable optimization if other languages are selected |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| { | ||
| prev_fname = std::move(fname); | ||
| } | ||
| else if (!prev_fname.empty() && prev_fname.size() == fname.size()) |
There was a problem hiding this comment.
Suggested change
| else if (!prev_fname.empty() && prev_fname.size() == fname.size()) | |
| else if (prev_fname.size() == fname.size()) |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| const std::string_view plang = std::string_view(prev_fname).substr(j, 2); | ||
| const std::string_view flang = std::string_view(fname).substr(j, 2); | ||
|
|
||
| if (plang != flang && s_ch_to_lang.count(plang) && s_ch_to_lang.count(flang)) |
There was a problem hiding this comment.
Suggested change
| if (plang != flang && s_ch_to_lang.count(plang) && s_ch_to_lang.count(flang)) | |
| if (plang != flang && s_ch_to_lang.contains(plang) && s_ch_to_lang.contains(flang)) |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
|
|
||
| const std::string_view flang = std::string_view(fname).substr(j, 2); | ||
|
|
||
| if (s_ch_to_lang.count(flang) && chosen_lang != flang) |
There was a problem hiding this comment.
Suggested change
| if (s_ch_to_lang.count(flang) && chosen_lang != flang) | |
| if (s_ch_to_lang.contains(flang) && chosen_lang != flang) |
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
| @@ -3854,6 +4007,15 @@ extern void ppu_precompile(std::vector<std::string>& dir_queue, std::vector<ppu_ | |||
| for (const file_info& info : file_queue) | |||
| { | |||
| total_files_size += info.file_size; | |||
|
|
|||
| if (!info.rec_name.empty()) | |||
There was a problem hiding this comment.
Kinda weird to take the negated path first.
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
Comment on lines
3910
to
3918
| usz j = 0; | ||
|
|
||
| for (; j < fname.size() - 7; j++) | ||
| { | ||
| if (prev_fname[j] != fname[j]) | ||
| { | ||
| break; | ||
| } | ||
| } |
There was a problem hiding this comment.
isn't this the same as
const usz j = prev_fname[j].find_first_not_of(fname[j]);
?
Megamouse
reviewed
Mar 11, 2024
rpcs3/Emu/Cell/PPUThread.cpp
Outdated
Comment on lines
3968
to
3970
| if (fname.ends_with(".self")) | ||
| { | ||
| if (prev_fname.size() == fname.size()) |
There was a problem hiding this comment.
This would probably be faster the other way around
elad335
force-pushed
the
postpone
branch
6 times, most recently
from
a8edced to
4a8a58c
Compare
|
@elad335 My Compile FW FULL SPEED 14600KF Thanks Brow !!!!! |
|
Failed to boot Guitar Hero 5
Log: |
elad335
force-pushed
the
postpone
branch
2 times, most recently
from
15295c2 to
b1c7f88
Compare
|
Failed to boot gt6 |
|
Test all games Bug Boot |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I noticed that more then 40% of functions examined in some executables, occur more than once throughout the executable. So, why not reuse their code when possible in order to reduce compilation and link time?
There are some exceptions, not all identical functions are truly identical in meaning if they are located elsewhere so I also check if they contain any relative branch that tragets external code. (which changes the meaning of the function)
Edit: because of the spectacular bugs I created when debugging this PR, I discovered a bug in sys_prx_stop_module that is fixed here. (turns it it can abort an ongoing starting process of PRX)