Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add some forgotten things to the fedora build instructions #16410

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

jordan4ibanez
Copy link

hi

@RipleyTom
Copy link
Contributor

Technically those are not required as you can build LLVM from the submodule with -DBUILD_LLVM=ON and you can also use our curl submodule with -DUSE_SYSTEM_CURL=OFF (both as cmake parameters).

But yeah in the current state the build instructions won't work if you don't have llvm and curl. If we change it that needs to be change it for all distros. Or we can specify those instructions in the build instructions.

@Megamouse Megamouse added OS: Linux Build and CI Anything related to the build process and continuous integration labels Dec 16, 2024
@Megamouse
Copy link
Contributor

Megamouse commented Dec 16, 2024

Technically those are not required as you can build LLVM from the submodule with -DBUILD_LLVM=ON and you can also use our curl submodule with -DUSE_SYSTEM_CURL=OFF (both as cmake parameters).

But yeah in the current state the build instructions won't work if you don't have llvm and curl. If we change it that needs to be change it for all distros. Or we can specify those instructions in the build instructions.

I think if you blindly install those in the first place then you won't change the build variables anyway.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Build and CI Anything related to the build process and continuous integration OS: Linux
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants