Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

windows: move config.yml and games.yml to /config/, move log files to /log #16494

Open
wants to merge 2 commits into
base: master
Choose a base branch
from

Conversation

Megamouse
Copy link
Contributor

@Megamouse Megamouse commented Jan 2, 2025

  • Moves games.yml to /config
  • Moves config.yml to /config
  • Moves log files to /log
  • Simplifies a bunch of #ifdef _WIN32 code

This moves the old file to the new location if there isn't a file already.

fixes #16478

@Megamouse
Copy link
Contributor Author

I've added the code for the log move.
It needs to be discussed by staff whether or not this should get merged.

@digant73
Copy link
Contributor

digant73 commented Jan 2, 2025

is the lock file RPCS3.buf related to log file? if so, it seems not moved on log folder

@Megamouse
Copy link
Contributor Author

No, why would it?

@digant73
Copy link
Contributor

digant73 commented Jan 2, 2025

No, it doesn't need to be moved to log folder if it is not related to log. Just asked to understand which module is using RPCS3.buf. If it is a lock file for the executable then (IMO) it is ok to leave it there

@Megamouse Megamouse changed the title windows: move config.yml and games.yml to /config/ windows: move config.yml and games.yml to /config/, move log files to /log Jan 2, 2025
@schm1dtmac
Copy link
Contributor

Any reason why this rearrangement is Windows-only, other than I guess the fact that RPCS3 binaries and configs on windows are all stored together in one loose folder unlike macOS/Linux/etc?

@Megamouse
Copy link
Contributor Author

Because on other OSs there already exists a specified config folder.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature request] Move "config.yml" and "games.yml" under the already existing and used "config" folder
3 participants