cellGem: Update controllers at 10 Hz in separate thread #16528
+143
−75
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Megamouse
force-pushed
the
cellGemUpdate
branch
3 times, most recently
from
205f62b to
dabcd46
Compare
elad335
reviewed
Jan 8, 2025
Megamouse
force-pushed
the
cellGemUpdate
branch
from
dabcd46 to
8720341
Compare
elad335
requested changes
Jan 8, 2025
|
|
||
| void wait_for_result() | ||
| { | ||
| if (!m_done) |
There was a problem hiding this comment.
Should be a while loop, code should not assume that wait is accurate and won't wake up spuriously
| } | ||
| } | ||
|
|
||
| gem_config_data& operator=(thread_state) |
| gem_config_data& operator=(thread_state) | ||
| { | ||
| wake_up(); | ||
| done(); |
There was a problem hiding this comment.
shouldn't done() be called exclusive by the thread? In case of emulation stop, PPUs should check their own state and not depend on notifications from others.
- Use thread_ctrl::wait_on() instead of atomic_t::wait
- Check ppu_thread::state if stopped before wait.
- Remove this line.
- If PPU wakes up prematurely on emulation stopping, add cpu_state::again to state.
There was a problem hiding this comment.
I'm assuming the = operators aren't necessary anymore then
Some games don't use cellGemGetInfo. Which means we had to reboot the game if the controller wasn't connected on boot. Updating controllers outside of the cell functions fixes this problem.
Megamouse
force-pushed
the
cellGemUpdate
branch
from
8720341 to
93bdd96
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Some games don't use cellGemGetInfo, which means we had to reboot the game if the controller wasn't connected on boot.
Updating controllers outside of the cell functions fixes this problem.