Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: replacing string position code with retain #50

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

chore: replacing string position code with retain #50

wants to merge 3 commits into from
+23 −33

Conversation

JustSimplyKyle
Copy link
Contributor

No description provided.

@JustSimplyKyle JustSimplyKyle force-pushed the chore/maven-retain-optimize branch from d3b01be to 69aff41 Compare October 2, 2023 14:53
@SiongSng SiongSng added the rust Pull requests that update Rust code label Oct 7, 2023
SiongSng
SiongSng requested changes Oct 8, 2023
View reviewed changes
Copy link
Member

@SiongSng SiongSng left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

先說聲抱歉，我太久沒看程式碼了🤣，我會盡快找時間 review 剩下的程式碼。

app/lib/api/gen/bridge_generated.dart Outdated Show resolved Hide resolved
@JustSimplyKyle JustSimplyKyle force-pushed the chore/maven-retain-optimize branch from 9e12b03 to 81edb96 Compare October 8, 2023 11:28
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@SiongSng SiongSng SiongSng requested changes

Assignees
No one assigned
Labels
rust Pull requests that update Rust code
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@JustSimplyKyle @SiongSng