Generate newsletters feed #282
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
willfurnass
reviewed
Jul 15, 2020
|
It seems the individual pages have feeds generated automatically already by Jekyll although there is no RSS button on the individual pages (you have to view the source to find them, but personally that is what I do for most RSS feeds I've found and follow). As such I think this PR is now redundant, perhaps if it is felt they should have greater prominence on the displayed pages (i.e. a button) we should address under a separate issue, I've put some thoughts in #685. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
While newsletters are still there own separate collection, they generate their own rss feed to subscribe to (in this case /newsletters.xml). Addresses #279