Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve Dockerfile and add Build action #70

Open
wants to merge 5 commits into
base: master
Choose a base branch
from

Conversation

Paillat-dev
Copy link
Contributor

@Paillat-dev Paillat-dev commented Apr 7, 2024

This pr improves the dockerfile by copying the files instead of cloning the repo in the container, which is much better honestly and shows I wasn't that experienced with docker when I first did this.

It also adds an action triggered on every pull request and push on the main branch that builds the docker image and publishes it at ghcr.io/RafaelSolVargas/Vulkan:master which is useful as it allows anyone to use it without needing to build the image, saving resources especially if running on cheap hardware.

Will ad docs on this same pr asap

Edit: No docs neede actually

@Paillat-dev Paillat-dev marked this pull request as ready for review April 9, 2024 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant