Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Dark/Light mode button placed in proper position #582

Merged
merged 25 commits into from
Feb 18, 2024

Conversation

AftabMankapure
Copy link
Contributor

Fixes Issue🛠️ #536

Closes #536

Description👨‍💻

Toggle button position is changed

Type of change📄

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)

How this has been tested✅

nav

Checklist✅

  • My code follows the style guidelines of this project
  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have added demonstration in the form of GIF/video file
  • I am an Open Source Contributor

Screenshots/GIF📷

nav

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @AftabMankapure, Welcome to the project Beautiify! 🎊
Thanks for your contribution! Your effort makes this project better. Keep it up! 🙌
Please wait for the PR to be reviewed. Happy Coding!! ✨

Copy link

netlify bot commented Feb 16, 2024

Deploy Preview for beautiify ready!

Name Link
🔨 Latest commit 7b75a15
🔍 Latest deploy log https://app.netlify.com/sites/beautiify/deploys/65d1c4e2ebc1860009257a91
😎 Deploy Preview https://deploy-preview-582--beautiify.netlify.app/
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site configuration.

@Rakesh9100
Copy link
Owner

Fix the button position in every pages, it is only fixed in home page @AftabMankapure

@Rakesh9100 Rakesh9100 added the question 🤔 Further information is requested label Feb 17, 2024
@AftabMankapure
Copy link
Contributor Author

pls check this PR

@Rakesh9100
Copy link
Owner

Fix the button position on every components cards page as well.

image

And why the menu items went little up, fix this @AftabMankapure

@Rakesh9100
Copy link
Owner

Fix the 2nd mentioned change in the above comment @AftabMankapure

@AftabMankapure
Copy link
Contributor Author

AftabMankapure commented Feb 18, 2024

Screenshot 2024-02-18 130520

menu is not going upper when we hover on it it match the size of toggle button
if we make same width of menu with toggle then after hover to menu it will go outside of nav bar

Screenshot 2024-02-18 130520

@Rakesh9100
Copy link
Owner

Navbar should not be altered in any case as it is now in the website, you can decrease the size of the button slightly and make sure not to increase the height of the navbar @AftabMankapure

@Rakesh9100
Copy link
Owner

I have fixed and merged ✨ @AftabMankapure

@Rakesh9100 Rakesh9100 changed the title [Bug] Dark/Light mode button is not placed proper position #536 Dark/Light mode button placed in proper position Feb 18, 2024
@Rakesh9100 Rakesh9100 merged commit 25d0c3e into Rakesh9100:main Feb 18, 2024
4 checks passed
@Rakesh9100 Rakesh9100 added Easy Low effort straightforward task Completed 🥳 PR successfully merged and issue resolved on completion JWOC JWOC Open Source Program and removed question 🤔 Further information is requested labels Feb 18, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Completed 🥳 PR successfully merged and issue resolved on completion Easy Low effort straightforward task JWOC JWOC Open Source Program
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Style] Dark/Light mode button is not placed proper position
2 participants