Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional switch to size_t (or R_xlen_t) to avoid conversion warnings from clang++-17 #1309

Merged
merged 3 commits into from
Jun 5, 2024

Conversation

eddelbuettel
Copy link
Member

This is a continuation of PR #1307 with a few changes -- with many remaining to be done. As we wrote in #1307:

Issue #1299 alerts to issues from the (very much opt-in, not (yet ?) compulsory) conversion warnings clang++17 can do. As I noticed a few from one of our own tests a first attempt squashed those.

This likely does not 'close' the issue so not adding the tag, but should do no harm.

Checklist

  • Code compiles correctly
  • R CMD check still passes all tests
  • Preferably, new tests were added which fail without the change
  • Document the changes by file in ChangeLog

Copy link
Contributor

@kevinushey kevinushey left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

Copy link
Member

@Enchufa2 Enchufa2 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@eddelbuettel eddelbuettel merged commit 5207973 into master Jun 5, 2024
16 checks passed
@eddelbuettel eddelbuettel deleted the bugfix/size_t_casts_two branch June 5, 2024 20:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants