-
Notifications
You must be signed in to change notification settings - Fork 995
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Add the check workflow with sanitizers enabled
- Loading branch information
Showing
2 changed files
with
52 additions
and
0 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1 @@ | ||
leak:libfontconfig.so |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,51 @@ | ||
on: | ||
push: | ||
branches: | ||
- master | ||
- GHA-sanitizers # during development | ||
workflow_dispatch: | ||
pull_request: | ||
|
||
name: R-CMD-check-sanitized | ||
|
||
concurrency: | ||
group: ${{ github.event.pull_request.number || github.run_id }} | ||
cancel-in-progress: true | ||
|
||
jobs: | ||
R-CMD-check-sanitized: | ||
runs-on: ubuntu-latest | ||
container: | ||
image: docker://ghcr.io/r-hub/containers/clang-asan | ||
|
||
strategy: | ||
fail-fast: true | ||
|
||
steps: | ||
- uses: actions/checkout@v4 | ||
|
||
- name: "Set things up" | ||
run: | | ||
# setting aside the other.Rraw dependencies for now (will need cache) | ||
Rscript -e 'pak::pak()' | ||
# this should at least help with the build step | ||
echo "MAKEFLAGS=-j$(nproc)" >> $GITHUB_ENV | ||
# fontconfig is known to leak; add more suppressions as discovered | ||
echo "LSAN_OPTIONS=suppressions=$(realpath .github/workflows/LSan.supp)" >> $GITHUB_ENV | ||
# disabled by default, so reenable (needs suppressions above) | ||
echo "ASAN_OPTIONS=detect_leaks=1" >> $GITHUB_ENV | ||
# otherwise there are literal jumps to ud1 in the code with no diagnostics | ||
sed -i 's/-fsanitize-trap\S*//g' /opt/R/devel-asan/lib/R/etc/Makeconf | ||
- name: "Build" | ||
run: R CMD build . | ||
|
||
- name: "Check" | ||
run: | | ||
set +e # expect some things to fail and keep going | ||
echo "::group::full R CMD check output" | ||
R CMD check --no-manual data.table_*.tar.gz; res1=$? | ||
echo "::endgroup::" | ||
perl -nle '(print, $a=1) if /: runtime error: |ERROR: LeakSanitizer/../SUMMARY.*Sanitizer/ }{ exit $a' data.table.Rcheck/**/*.Rout*; res2=$? | ||
# fail if R CMD check had failed or if sanitizer output found | ||
[ $res1 -eq 0 ] && [ $res2 -eq 0 ] |