Update the definition of logpdf_optimized for Gaussians

ReactiveBayes · Nov 2, 2023 · d7af2d9 · d7af2d9
1 parent de097b4
commit d7af2d9
Showing 1 changed file with 2 additions and 10 deletions.
diff --git a/src/distributions/normal_family/normal_family.jl b/src/distributions/normal_family/normal_family.jl
@@ -461,20 +461,12 @@ function BayesBase.compute_logscale(
     return -(v_logdet + n * log2π) / 2 - dot3arg(m, v_inv, m) / 2
 end
 
-BayesBase.logpdf_optimized(dist::UnivariateNormalDistributionsFamily) = convert(Normal, dist)
-BayesBase.logpdf_optimized(dist::MultivariateNormalDistributionsFamily) = convert(MvNormal, dist)
+BayesBase.logpdf_optimized(dist::UnivariateNormalDistributionsFamily) = convert(NormalMeanPrecision, dist)
+BayesBase.logpdf_optimized(dist::MultivariateNormalDistributionsFamily) = convert(MvNormalMeanPrecision, dist)
 
 BayesBase.sampling_optimized(dist::UnivariateNormalDistributionsFamily) = convert(Normal, dist)
 BayesBase.sampling_optimized(dist::MultivariateNormalDistributionsFamily) = convert(MvNormal, dist)
 
-function BayesBase.logpdf_sampling_optimized(
-    dist::Union{UnivariateNormalDistributionsFamily, MultivariateNormalDistributionsFamily}
-)
-    # For Gaussian both sample and logpdf are the same in terms of optimality
-    optimal = logpdf_optimized(dist)
-    return (optimal, optimal)
-end
-
 # Sample related
 
 ## Univariate case