Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Dirichlet tensor #219
Dirichlet tensor #219
Changes from 2 commits
93047b2
e5e08e3
d3b5f1a
f244d1c
603d989
bfc7466
de2e32f
6a9df05
d8ccd98
c399f37
c033071
ff5cf02
0977bc3
d1bfa07
baf0514
3e83feb
b28e67e
1339467
e38405f
fd790dd
6a7b028
6c9d756
40f08e2
78026b8
e43b376
678af98
89dd0ba
bd657cb
2aba23d
2aa166d
bcebba4
159e035
6160272
e506a5d
2c8bd8c
bbba975
85d437a
f38bfe0
f94b302
4dcb512
83da858
b042beb
0e327fa
54ef2d6
19a9446
3e87207
5791da8
5253fbe
3ac5e68
1432769
d50c6d5
b31c87d
4da7225
c82eaac
ecd1cdf
f3ef44a
66601a4
4af1f19
94bbd82
d6e3700
0784837
a690ace
410dad6
f8cdeec
6283aa5
f430acf
b5a43e2
336bb8c
3170cef
69898b8
d6e6de6
5bc0e86
2841038
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
extract_collection(dist::TensorDirichlet) = (view(dist.a, :, i) for i in CartesianIndices(Base.tail(size(dist.a))))
?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Yes with a '@view' it will be way better. I will take your suggestion.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
In one of the
vague
methods (with a tuple), you specify the type of ones, while in another, you don't. Is there any reason why you aren't writing it like this?There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
No specific reason, I missed this difference.
Float64 seems to be the default type, so it should be the same.
I will add the
Float64
argument for clarity.Thanks
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
It's not a comment, this is the documentation make it a docstring, smt like this