Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Vector with NaN is improper Dirichlet in natural parameters #223

Merged
merged 1 commit into from
Jan 8, 2025
Merged

Vector with NaN is improper Dirichlet in natural parameters #223

merged 1 commit into from
Jan 8, 2025

Conversation

wouterwln
Copy link
Member

For some reason (because isless(-1, NaN) returns true), a vector of [Nan, 1.0] was regarded as a proper natural parameter for a Dirichlet distribution. This PR fixes that bug

@wouterwln wouterwln requested a review from bvdmitri January 8, 2025 14:53
bvdmitri
bvdmitri approved these changes Jan 8, 2025
View reviewed changes
Copy link
Member

@bvdmitri bvdmitri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch @wouterwln

@wouterwln wouterwln merged commit 13249ec into main Jan 8, 2025
2 checks passed
@wouterwln wouterwln deleted the dirichlet_nan_natural_parameter_space branch January 8, 2025 15:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@bvdmitri bvdmitri bvdmitri approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@wouterwln @bvdmitri