Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Rename preview flag in redirects and use feature flag for integrations #2675

Merged
merged 1 commit into from
Oct 30, 2023

Conversation

karelhala
Copy link
Contributor

Description

Since we want to release integrations + sources on monday 30th Oct let's prepare the redirects as well. This PR also includes renaming of preview flag o feature flag in routes as it makes more sence that way.

TODO

Merge on 30th Oct.

@karelhala karelhala requested a review from a team October 27, 2023 10:26
@codecov-commenter
Copy link

codecov-commenter commented Oct 27, 2023

Codecov Report

Merging #2675 (64ed516) into master (8dc778a) will decrease coverage by 0.17%.
The diff coverage is n/a.

❗ Current head 64ed516 differs from pull request most recent head c6b332c. Consider uploading reports for the commit c6b332c to get more accurate results

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2675      +/-   ##
==========================================
- Coverage   57.37%   57.20%   -0.17%     
==========================================
  Files          94       94              
  Lines        2862     2860       -2     
  Branches      668      588      -80     
==========================================
- Hits         1642     1636       -6     
- Misses       1144     1223      +79     
+ Partials       76        1      -75     

see 26 files with indirect coverage changes

@karelhala karelhala marked this pull request as ready for review October 30, 2023 07:58
@karelhala
Copy link
Contributor Author

/retest

1 similar comment
@karelhala
Copy link
Contributor Author

/retest

@karelhala karelhala merged commit d8eadf6 into RedHatInsights:master Oct 30, 2023
6 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants