Combine suggester restuls. #2681
Conversation
Hyperkid123
requested review from
ryelo,
karelhala and
florkbr
as code owners
Codecov Report
@@ Coverage Diff @@
## master #2681 +/- ##
==========================================
+ Coverage 52.32% 57.21% +4.89%
==========================================
Files 95 95
Lines 2515 2861 +346
Branches 456 588 +132
==========================================
+ Hits 1316 1637 +321
- Misses 827 1223 +396
+ Partials 372 1 -371
|
| function parseSuggestions(suggestions: SearchAutoSuggestionResultItem[] = []) { | ||
| return suggestions.map((suggestion) => { | ||
| const [allTitle, bundleTitle, abstract] = suggestion.term.split(AUTOSUGGEST_TERM_DELIMITER); | ||
| const url = new URL(suggestion.payload); |
There was a problem hiding this comment.
Wouldn't it be better to directly destruct the pathname here? const { pathname} = ...
There was a problem hiding this comment.
It's a class, not an object. Destructing classes might be dangerous.
| const [allTitle, bundleTitle, abstract] = suggestion.term.split(AUTOSUGGEST_TERM_DELIMITER); | ||
| const url = new URL(suggestion.payload); | ||
| const pathname = url.pathname; | ||
| const item = { |
There was a problem hiding this comment.
Is there specific reason to assign this to a const instead of directly constructing it when returning value?
There was a problem hiding this comment.
None apart from better readability.
Hyperkid123
force-pushed
the
use-improved-suggester
branch
2 times, most recently
from
9c26a73 to
a1f645d
Compare
Hyperkid123
force-pushed
the
use-improved-suggester
branch
from
a1f645d to
f10f1f7
Compare
Combine results of the default and the improved suggester results.