Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Use RSPack to build chrome #2914

Draft
wants to merge 7 commits into
base: master
Choose a base branch
from
Draft

Use RSPack to build chrome #2914

wants to merge 7 commits into from

Conversation

Hyperkid123
Copy link
Contributor

@Hyperkid123 Hyperkid123 commented Aug 7, 2024 •
edited
Loading

Changes

  • move the build to RSpack
  • shuffled some functions to not conflict with the react-refresh requirements (not mixing component and exporting non component modules from them)

TODO

  • verify services have latest version of the module federation sharing config

old notes

Experimenting with decoupled module federation from webpack.

Notes:

  • Refresh plugin needs to be reconfigured in order to not cause false positive errors during shell init phase
  • There is an issue with shared scope between MFE and Vanilla plugins, seems to be some sort of race conditions, sometimes the child modules are unable to access singleton instances. Problematic for React context and hooks
    • the webpack singleton imports seem to be overriding the shared scope. It should be fixed by forbidding imports of core singleton packages from remote modules

@Hyperkid123
Copy link
Contributor Author

/retest

@Hyperkid123 Hyperkid123 force-pushed the mfe branch 2 times, most recently from 0a505f1 to 794f245 Compare October 2, 2024 12:01
@Hyperkid123 Hyperkid123 changed the title Use mfe plugin for chrome shell Use RSPack to build chrome Oct 2, 2024
@Hyperkid123
Use mfe plugin for chrome shell
7d484bb 
Notes:
- Refresh plugin needs to be reconfigured in order to not cause false positive errors during shell init phase
- There is an issue with shared scope between MFE and Vanilla plugins, seems to be some sort of race conditions, sometimes the child modules are unable to access singleton instances. Problematic for React context and hooks
@Hyperkid123
Enable RSPACK build.
6b1e9bc
@Hyperkid123
Add sample vite integration
2ecd958
@Hyperkid123
Update rspack to v1
539f5cc
@Hyperkid123
Remove mixed React components and other exports.
e565443
@Hyperkid123 Hyperkid123 requested a review from a team October 2, 2024 12:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@ryelo ryelo Awaiting requested review from ryelo ryelo will be requested when the pull request is marked ready for review ryelo is a code owner

@karelhala karelhala Awaiting requested review from karelhala karelhala will be requested when the pull request is marked ready for review karelhala is a code owner

@florkbr florkbr Awaiting requested review from florkbr florkbr will be requested when the pull request is marked ready for review florkbr is a code owner

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@Hyperkid123