fix(sentry): Update sentry plugin to always initialize | workflow update #2995
+10
−27
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adonispuente
requested review from
Hyperkid123,
ryelo,
karelhala and
florkbr
as code owners
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This updates the sentry flow to always upload debugIds when the app is built, and upload source maps only when the variable is defined. Source maps are only uploaded with an active authKey present in the plugin.
Currently, the process.env variable will only be defined inside of the sentry workflow. The automation for chrome specifically is done on a local set up due to auth issues, but its important to have the workflow in place for future enhancements.
This change has been implemented in three other apps and has been confirmed to further enhance the bugs reported in sentry