Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Refactor and Enhance MobileSidebar UI #38

Merged
merged 3 commits into from
Jan 10, 2025
Merged

Refactor and Enhance MobileSidebar UI #38

merged 3 commits into from
Jan 10, 2025

Conversation

charlottewiltshire0
Copy link
Collaborator

PR Content:

  • Refactored the MobileSidebar component to improve UI, including the logo and close button.
  • Updated the Sheet component.
  • Added a translation for the "Discord" button.
  • Fixed a bug where the sidebar menu wouldn't close when clicking a link. Reported by the user theoriginalspy: bug report link.

@charlottewiltshire0 charlottewiltshire0 added enhancement New feature or request fix labels Jan 10, 2025
@sonarqubecloud SonarQubeCloud
Copy link

Quality Gate Passed Quality Gate passed

Issues
0 New issues
0 Accepted issues

Measures
0 Security Hotspots
0.0% Coverage on New Code
0.0% Duplication on New Code

See analysis details on SonarQube Cloud

decryptedchaos
decryptedchaos approved these changes Jan 10, 2025
View reviewed changes
Copy link
Member

@decryptedchaos decryptedchaos left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good

@charlottewiltshire0 charlottewiltshire0 merged commit 14dc0c9 into master Jan 10, 2025
5 checks passed
@charlottewiltshire0 charlottewiltshire0 deleted the feature/sidebar-mobile-improvements branch January 10, 2025 16:36
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@decryptedchaos decryptedchaos decryptedchaos approved these changes

Assignees
No one assigned
Labels
enhancement New feature or request fix
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@charlottewiltshire0 @decryptedchaos