fix nan #81
fix nan #81
Conversation
for more information, see https://pre-commit.ci
|
Looks good! |
reproschema/redcap2reproschema.py
Outdated
| @@ -420,7 +420,15 @@ def process_row( | |||
| # ) | |||
|
|
|||
| elif key in ADDITIONAL_NOTES_LIST and value: | |||
| notes_obj = {"source": "redcap", "column": key, "value": value} | |||
| # Convert value to string, handling NaN explicitly | |||
| value_str = "NaN" if pd.isna(value) else str(value).strip() | |||
There was a problem hiding this comment.
do we really want to do this or skip nans?
There was a problem hiding this comment.
good question. so in the b2ai case, what happens when we have "value": NaN? @ibevers what do you mean by "Items that have NaN in them don't work in reproschema-ui." they won't appear in the UI or they can't proceed to the next one?
|
i left some suggestions, but we also need to check for |
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
Co-authored-by: Satrajit Ghosh <satrajit.ghosh@gmail.com>
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
for more information, see https://pre-commit.ci
|
we made changes to handle "nan" when converting from redcap to reproschema; however, we are failing |
regarding this issue
sensein/b2ai-redcap2rs#5