Skip to content

Commit

Permalink
fix NOTES
Browse files Browse the repository at this point in the history
  • Loading branch information
DivadNojnarg committed May 25, 2024
1 parent 23d86b2 commit 895c7c5
Show file tree
Hide file tree
Showing 8 changed files with 20 additions and 10 deletions.
2 changes: 1 addition & 1 deletion R/f7-inputs.R
Original file line number Diff line number Diff line change
Expand Up @@ -1746,7 +1746,7 @@ createOptions <- function(
#' This only works with elements having
#' an input HTML tag.
#'
#' @param id Form unique id. Using input$<id> gives
#' @param id Form unique id. Using `input$<id>` gives
#' the form result.
#' @param ... A list of input elements.
#'
Expand Down
2 changes: 1 addition & 1 deletion R/f7Messages.R
Original file line number Diff line number Diff line change
Expand Up @@ -118,7 +118,7 @@ updateF7MessageBar <- function(inputId, value = NULL, placeholder = NULL,
#' @param avatar Sender avatar URL string.
#' @param textHeader Message text header.
#' @param textFooter Message text footer.
#' @param image Message image HTML string, e.g. <img src="path/to/image">. Can be used instead of imageSrc parameter.
#' @param image Message image HTML string, e.g. `<img src="path/to/image">`. Can be used instead of imageSrc parameter.
#' @param imageSrc Message image URL string. Can be used instead of image parameter.
#' @param cssClass Additional CSS class to set on message HTML element.
#' @rdname messages
Expand Down
2 changes: 1 addition & 1 deletion R/f7Popup.R
Original file line number Diff line number Diff line change
Expand Up @@ -5,7 +5,7 @@
#'
#' @param ... UI elements for the body of the popup window.
#' @param id Popup unique id. Useful if you want to access the popup state.
#' input$<id> is TRUE when the popup is opened and inversely.
#' `input$<id>` is TRUE when the popup is opened and inversely.
#' @param title Title for the popup window, use \code{NULL} for no title.
#' @param backdrop Enables Popup backdrop (dark semi transparent layer behind).
#' Default to \code{TRUE}.
Expand Down
16 changes: 13 additions & 3 deletions cran-comments.md
Original file line number Diff line number Diff line change
@@ -1,10 +1,20 @@
## Test environments
* RStudio Workbench, R-4.2.2.
* Local R-4.4.0.
* `rhub::check_for_cran()`.
* win-builder (devel and release).

## R CMD check results
There were no ERRORs or WARNINGs or NOTEs.

## Note
This release also fixes a note in https://cran.r-project.org/web/checks/check_results_shinyMobile.html.
## Reverse dependencies

This release slightly affects `{LFApp}` with 2 deprecation warnings. Authors have been contacted and a pull request has been submited: https://github.com/fpaskali/LFApp/pull/8.

* checking whether package ‘LFApp’ can be installed ... WARNING
```
Found the following significant warnings:
Warning: The `hairlines` argument of `f7Block()` is deprecated as of shinyMobile 2.0.0.
Warning: The `multiCollapse` argument of `f7Accordion()` is deprecated as of shinyMobile
See ‘/Users/davidgranjon/david/RinteRface/shinyMobile/revdep/checks.noindex/LFApp/new/LFApp.Rcheck/00install.out’ for details.
```
2 changes: 1 addition & 1 deletion man/f7Popup.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/form-inputs.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion man/messages.Rd

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion vignettes/shinyMobile.Rmd
Original file line number Diff line number Diff line change
Expand Up @@ -815,7 +815,7 @@ shinyApp(

### Multi Layout

The layout for __multiple pages__ is covered in a [separate article](https://shinymobile.rinterface.com/articles/multipages).
The layout for __multiple pages__ is covered in a separate article.

# Gadgets

Expand Down

0 comments on commit 895c7c5

Please sign in to comment.