Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: Subscription class for SSE #2280

Draft
wants to merge 91 commits into
base: master
Choose a base branch
from
Draft

feat: Subscription class for SSE #2280

wants to merge 91 commits into from
+349 −3

Conversation

RobinTail
Copy link
Owner

Addition to #2238

@RobinTail RobinTail added the enhancement New feature or request label Jan 2, 2025
@RobinTail
Copy link
Owner Author

I think it would be better to make it in v22

@RobinTail RobinTail force-pushed the subscribe-method branch 2 times, most recently from 708edb0 to c663d7e Compare January 2, 2025 20:37
@RobinTail RobinTail changed the base branch from master to make-v22 January 2, 2025 20:37
@RobinTail RobinTail added this to the v22 milestone Jan 2, 2025
@coveralls-official Coveralls Official
Copy link

coveralls-official bot commented Jan 2, 2025 •
edited
Loading

Coverage Status

coverage: 100.0%. remained the same
when pulling 08a09bd on subscribe-method
into aa2a2f6 on master.

This was referenced Jan 3, 2025
Merged
Merged
RobinTail added a commit that referenced this pull request Jan 3, 2025
@RobinTail
Allow type params on makeArrowFn() (#2281)
646bac8 
Needed for #2280
RobinTail
RobinTail commented Jan 4, 2025
View reviewed changes
example/example.client.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 4, 2025
View reviewed changes
src/integration-helpers.ts Outdated Show resolved Hide resolved
RobinTail
RobinTail commented Jan 4, 2025
View reviewed changes
src/integration.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail changed the title Feat: subscribe() method for SSE feat(v22): subscribe() method for SSE Jan 4, 2025
@RobinTail RobinTail mentioned this pull request Jan 6, 2025
Merged
RobinTail added a commit that referenced this pull request Jan 6, 2025
@RobinTail
Organizing Typescipt API (#2287)
2a4d52f 
First I wanna keep every helper using typescript factory in one place.
This should allow to use "integration helpers" file for bigger and
higher order entities of the code production.
That will be helpful for #2280 that makes "integraton" file even bigger
and less readable.
RobinTail added a commit that referenced this pull request Jan 13, 2025
@RobinTail
ref(v22): Integration base (#2299)
9bf42f1 
Bricks for the building: this should make the `Integration` class a high
level orchestrator of the codegen.

This should organize the code for readability.
Can cause minor conflicts for #2280
RobinTail added a commit that referenced this pull request Jan 13, 2025
@RobinTail
Cherry-picking parseRequest(), substitute() and ensureTypeNode() from #…
7a65485 
…2280.
@RobinTail RobinTail mentioned this pull request Jan 13, 2025
Merged
RobinTail added a commit that referenced this pull request Jan 13, 2025
@RobinTail
ref(v22): parseRequest() and substitute() functions (#2303)
ebf8b47 
This should extract the refactoring and general improvement from #2280
@RobinTail RobinTail marked this pull request as draft January 13, 2025 20:35
RobinTail
RobinTail commented Jan 14, 2025
View reviewed changes
example/example.client.ts Outdated Show resolved Hide resolved
@RobinTail RobinTail mentioned this pull request Jan 14, 2025
Merged
RobinTail added a commit that referenced this pull request Jan 14, 2025
@RobinTail
Renaming ExpressZodAPIClient to just Client (#2313)
88a0a66 
1. Since I also wanna make subscription class in #2280 
2. In the era of modules there is no longer need to have a unique name
@RobinTail RobinTail mentioned this pull request Jan 15, 2025
Merged
RobinTail added a commit that referenced this pull request Jan 15, 2025
@RobinTail
ref(v22): makePublicClass() arguments (#2314)
f3e1450 
should make it easier to feat #2280
@RobinTail RobinTail changed the title feat(v22): subscribe() method for SSE feat(v22): Subscription class for SSE Jan 15, 2025
Base automatically changed from make-v22 to master January 24, 2025 08:39
@RobinTail RobinTail changed the title feat(v22): Subscription class for SSE feat: Subscription class for SSE Jan 24, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
enhancement New feature or request
Projects
None yet
Milestone
v22
Development

Successfully merging this pull request may close these issues.
1 participant
@RobinTail