-
Notifications
You must be signed in to change notification settings - Fork 15
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add genesight #278
Add genesight #278
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This all looks great. A couple questions..
What is the change to the kgx_file_converter for? I'm not sure I understand that.
I like the change to the automat graph ids, but I'm hesitant because it will break the continuity of the existing graph output directories and make them look like different graphs. Is there a technical reason you think it should be done or just style? I think I agree either way but I'm curious.
Note that I just pushed some changes to that specific part of the kgx_file_converter (and immediately saw a bug that I'm about to push a fix for hah) but the changes shouldn't affect what you have here |
Me either. I am afraid I may have branched off of the wrong branch.
I am going to move these changes to a new PR that is from a clean master branch. |
adding LINCS & MetabolomicsWorkbench implementation where the code is nearly identical per parser. A cfde config file specifies the details.