regression: no sorting by status in rooms.membersByOrderedByRole

[abhinavkrin]

Proposed changes (including videos or screenshots)

In members list, the members should be ordered by rolePriority, then by status and then by username/name.
This pr fixes the missing sort by status.

Issue(s)

Steps to test or reproduce

Further comments

CORE-937

[dionisio-bot]

Looks like this PR is not ready to merge, because of the following issues:

• This PR is missing the 'stat: QA assured' label

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

[changeset-bot]

⚠️ No Changeset found

Latest commit: 135840b

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (5a5ffb0) to head (135840b).

Additional details and impacted files

@@                Coverage Diff                @@
##           release-7.3.0   #35004      +/-   ##
=================================================
- Coverage          59.17%   59.17%   -0.01%     
=================================================
  Files               2821     2821              
  Lines              68140    68139       -1     
  Branches           15155    15155              
=================================================
- Hits               40325    40324       -1     
  Misses             24981    24981              
  Partials            2834     2834              

Flag	Coverage Δ
unit	74.99% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

[github-actions]

PR Preview Action v1.6.0
🚀 View preview at https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35004/
Built to branch gh-pages at 2025-01-23 19:11 UTC. Preview will be ready when the GitHub Pages deployment is complete.

[dougfabris]

please use our pkg mock-providers in order to mock the unit test