Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: filter thread messages in room message query #35013

Draft
wants to merge 1 commit into
base: develop
Choose a base branch
from

Conversation

Dnouv
Copy link
Member

@Dnouv Dnouv commented Jan 23, 2025

Proposed changes (including videos or screenshots)

  • Currently when making a call to the bridge API for reading room messages, or reading unread messages, all the messages including the ones inside a thread are being sent, which makes it complex to filter out and group together a single thread messages
  • With introduction of a new option, threadMsgCount would be shown on the main message of a thread, the id of this message can then be used to fetch all the threaded messages using the thread read bridge.

Issue(s)

Steps to test or reproduce

Further comments

RCAI4-5

Copy link
Contributor

dionisio-bot bot commented Jan 23, 2025

Looks like this PR is not ready to merge, because of the following issues:

  • This PR is missing the 'stat: QA assured' label
  • This PR is missing the required milestone or project

Please fix the issues and try again

If you have any trouble, please check the PR guidelines

Copy link

changeset-bot bot commented Jan 23, 2025

⚠️ No Changeset found

Latest commit: 45cb964

Merging this PR will not cause a version bump for any packages. If these changes should not result in a new version, you're good to go. If these changes should result in a version bump, you need to add a changeset.

This PR includes no changesets

When changesets are added to this PR, you'll see the packages that this PR includes changesets for and the associated semver types

Click here to learn what changesets are, and how to add one.

Click here if you're a maintainer who wants to add a changeset to this PR

Copy link

codecov bot commented Jan 23, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 59.17%. Comparing base (a5b4584) to head (45cb964).
Report is 8 commits behind head on develop.

Additional details and impacted files

Impacted file tree graph

@@           Coverage Diff            @@
##           develop   #35013   +/-   ##
========================================
  Coverage    59.17%   59.17%           
========================================
  Files         2822     2822           
  Lines        68124    68124           
  Branches     15149    15149           
========================================
  Hits         40314    40314           
  Misses       24978    24978           
  Partials      2832     2832           
Flag Coverage Δ
unit 75.00% <ø> (ø)

Flags with carried forward coverage won't be shown. Click here to find out more.

Copy link
Contributor

PR Preview Action v1.6.0

🚀 View preview at
https://RocketChat.github.io/Rocket.Chat/pr-preview/pr-35013/

Built to branch gh-pages at 2025-01-23 11:11 UTC.
Preview will be ready when the GitHub Pages deployment is complete.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant