LogChannelLocation 2.0 #17
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
KyNorthstar
commented
Jun 9, 2023
KyNorthstar
added a commit
that referenced
this pull request
Jun 9, 2023
- Addressing PR comments - Cleaning up the code & docs a bit - Adding SwiftUI-style extension statics
KyNorthstar
added a commit
that referenced
this pull request
Jun 9, 2023
Instead of a hardcoded enum, it's now protocols, of which you can create custom instances. To do this, I also needed to introduce generics to `LogChannel`, and so I introduced a marker protocol that it now conforms to. Also introduced a bunch of `.default`s.
- Addressing PR comments - Cleaning up the code & docs a bit - Adding SwiftUI-style extension statics
KyNorthstar
added a commit
that referenced
this pull request
Jun 9, 2023
KyNorthstar
force-pushed
the
feature/New-LogChannel-Architecture
branch
from
d390715 to
1823dd8
Compare
KyNorthstar
added a commit
that referenced
this pull request
Jun 9, 2023
KyNorthstar
force-pushed
the
feature/New-LogChannel-Architecture
branch
from
1823dd8 to
fa60446
Compare
KyNorthstar
force-pushed
the
feature/New-LogChannel-Architecture
branch
from
89e81e9 to
5a6dbca
Compare
That's just unnecessarily wasteful
KyNorthstar
force-pushed
the
feature/New-LogChannel-Architecture
branch
from
5a6dbca to
8779490
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instead of a hardcoded enum, it's now protocols, of which you can create custom instances.
To do this, I also needed to introduce generics to
LogChannel, and so I introduced a marker protocol that it now conforms to.Also introduced a bunch of
.defaults.Of course, this requires a 0.6.0