Add late name resolution pass #2620

CohenArthur · 2023-09-12T08:53:55Z

This is a massive draft PR which I'll split in multiple tinier ones

expected: nodiscard
optional: Add [[nodiscard]]
late
sesh: Add late name resolution 2.0
session manager
ast: change SimplePath, PathInExpression etc's API
default: Add visit_function_param helper function
rib
toplevel
ctx: Add labels foreverstack
forever-stack: Fix basic get logic
late
foreverstack: Specialize get for Namespace::Labels
forever stack: Fix resolve_path signature
late: resolve path
early: resolve path
late: Add test
nameresolutionctx: Store mappings in ctx
early: [f | d]: Add macro invocations to mappings
late: Start setting up builtin types
late: builtins
late: Start storing mappings properly in the resolver
early
nameresolutionctx: Keep map of resolved usages
toplevel: Add comment about running the collector twice
ast: Add NodeId to UseTree base class
default resolver: Visit UseDeclarations
forever stack: Do not copy segment when dereferencing iterator in find_starting_point [other functions too?]
early: Move usedec resolving to TopLevel
toplevel: Start usedec resolution
default: [f] it to [d] the other
toplevel: Handle use declarations properly
session-manager: [f] STart dumping name reoslution pass
toplevel: Resolve use decls more properly
toplevel: Start cleanup of import handling
add more name res test casaes
immutable nrctx
session manager: Init Immutable name resolver
nrctx: add resolved lookup
typecheck: Fetch ImmutableNRCtx
foreverstack: Add to_canonical_path method
foreverstack: Add to_rib method
typecheck: Start using nr2.0 properly
backend: Use new name resolver where necessary
nr2.0: Start using newtype pattern for Usage and Definition
rib: Add base for storing shadowable ids
typecheck path: wip
late: Setup builtin types properly
rib: Add shadowable definitions on a per definition level
forever stack: Use new Rib::Definition API
toplevel: Add note about resolving glob imports
default: Visit external functions properly
compile: use new rib API
type-check-type: Smol cleanup in format string

matthewjasper · 2023-09-12T10:10:32Z

gcc/rust/resolve/rust-late-name-resolver-2.0.cc

+  DefaultResolver::visit (let);
+
+  // how do we deal with the fact that `let a = blipbloup` should look for a
+  // label and cannot go through function ribs, but `let a = blipbloup()` can?


let a = blipbloup can look through function ribs if blipbloup is a function, constant or static item.

gcc/rust/resolve/rust-late-name-resolver-2.0.cc

matthewjasper · 2023-09-12T12:53:17Z

gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc

@@ -54,6 +63,11 @@ TopLevel::insert_or_error_out (const Identifier &identifier, const T &node,
 void
 TopLevel::go (AST::Crate &crate)
 {
+  // we do not include builtin types in the top-level definition collector, as


use i32; is allowed for editions >= 2018

matthewjasper · 2023-09-12T12:59:27Z

gcc/rust/resolve/rust-default-resolver.cc

+  auto def_fn = [this, &function] () {
+    for (auto &param : function.get_function_params ())
+      {
+	// TODO: So extern function params are not patterns?


Rustc will parse any pattern, but it's an error if the pattern is anything other than an identifier or _ after expansion.

matthewjasper · 2023-09-12T13:06:41Z

gcc/rust/resolve/rust-toplevel-name-resolver-2.0.cc

+  // so what is the plan for glob imports
+  // 1. figure out the rib which contains all the exports, in each namespace
+  // 2. for that namespace, go through all the nodes
+  // 3. filter out the exported ones (is that correct?)


It should be all nodes that are visible (not private) from the import, even other imports. You do need to handle cycles somehow.

dkm · 2023-09-13T16:47:42Z

gcc/rust/backend/rust-compile-base.cc

+
+      auto candidate = nr_ctx.values.to_rib (body_mappings.get_nodeid ());
+
+      // FIXME: Ugly


P-E-P · 2023-09-19T08:19:43Z

optional: Add [[nodiscard]]

Isn't this C++17 ? Won't it break with 4.8 ?

CohenArthur · 2023-09-21T12:09:14Z

optional: Add [[nodiscard]]

Isn't this C++17 ? Won't it break with 4.8 ?

yeah, this does break it. I'll remove the commits. it's very useful for testing however and works in C++11, the compiler just complains that this attribute is in C++17 and still applies it

CohenArthur · 2023-11-08T22:48:00Z

@matthewjasper I opened issues for all your comments, but I don't think I'll be addressing them in this PR as the goal for this one is to not add any regressions, and thus it can be in an incomplete state. thanks a lot for having taken the time to review it :)

…ableNRCtx

The resolver did report duplicate symbols when being run multiple times even if the node id was the same. This commit adds an additional condition, the error will only be reported if the existing node id is different from the current node id. gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::insert_or_error_out): Add new constraint to duplicate errors. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change the test's name resolution algorithm to 2.0. gcc/testsuite/ChangeLog: * rust/compile/name_resolution12.rs: Add name resolution 2.0 flag. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change test name resolution algorithm to 2.0. gcc/testsuite/ChangeLog: * rust/compile/name_resolution13.rs: Add compile flag to use the new name resolution 2.0 algorithm. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

The compiler did not emit any warning when a same target was declared from different sources. gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::handle_use_dec): Use the new dict to track down already resolved use declarations. * resolve/rust-toplevel-name-resolver-2.0.h: Add new dict to store previous use declarations. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

The original error text did not match the test nor rustc's behavior. gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (TopLevel::visit): Update error text to match rustc's one. gcc/testsuite/ChangeLog: * rust/compile/name_resolution14.rs: Update the test with error code. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change the name resoltion algorithm to 2.0 in this test. gcc/testsuite/ChangeLog: * rust/compile/name_resolution14.rs: Add flag to activate name resolution 2.0. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change name resolution algorithm in name resolution test 18 to the new name resolution 2.0. gcc/testsuite/ChangeLog: * rust/compile/name_resolution17.rs: Add flag to use new name resolution algorithm. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change the name resolution algorithm to name resolution 2.0 in one name resolution test. gcc/testsuite/ChangeLog: * rust/compile/name_resolution18.rs: Add flag to enable name resolution algorithm. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

The resolver was emitting an error when meeting the same symbol twice. What is important here is the origin of the resolved symbol, we should emit an error when the name is similar but the symbol isn't be not when the resolver is simply meeting the exact same symbol. gcc/rust/ChangeLog: * resolve/rust-toplevel-name-resolver-2.0.cc (insert_macros): Add constraint over the ast node id. (TopLevel::visit): Likewise. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

P-E-P · 2024-05-29T13:58:07Z

@CohenArthur Should we close this PR ?

matthewjasper reviewed Sep 12, 2023

View reviewed changes

dkm reviewed Sep 13, 2023

View reviewed changes

CohenArthur force-pushed the arthur/dev branch 3 times, most recently from 177a4b3 to 5cd813b Compare September 14, 2023 16:14

CohenArthur force-pushed the arthur/dev branch 4 times, most recently from 2854b1b to 6c2145f Compare September 22, 2023 14:17

CohenArthur force-pushed the arthur/dev branch from 6c2145f to 08f26b4 Compare November 8, 2023 21:57

This was referenced Nov 8, 2023

let bindings can look through function ribs if binding to a function or global #2730

Closed

Allow use-ing builtin types in Rust editions >= 2018 #2731

Open

Handle cycles in name resolution 2.0 #2733

Open

CohenArthur force-pushed the arthur/dev branch 11 times, most recently from a79741a to 83b9bac Compare November 14, 2023 20:17

CohenArthur mentioned this pull request Nov 15, 2023

Add ForeverStack APIs for Name Resolution 2.0 #2739

Merged

CohenArthur force-pushed the arthur/dev branch 2 times, most recently from 01755c2 to 6a5265e Compare November 15, 2023 10:02

CohenArthur force-pushed the arthur/dev branch from 6a5265e to bf97c5e Compare November 15, 2023 13:59

CohenArthur force-pushed the arthur/dev branch from bf97c5e to 022d75c Compare December 14, 2023 16:18

CohenArthur and others added 26 commits December 14, 2023 17:59

immutable nrctx: new

8c6d4da

sesh: [wip][from here tests don't work] Add late name resolution 2.0

ab87d01

tests: [wip] [fmeup] delete failing tests for now

12e8a39

session-manager: [fix me] Start dumping name resolution pass

22115df

session manager: Init Immutable name resolver

af8c0bd

nrctx: add resolved lookup

7da69cb

typecheck: [tests fail from here] [needs f'ed up commits] Fetch Immut…

5a19a7c

…ableNRCtx

typecheck: Start using nr2.0 properly

62f1371

backend: Use new name resolver where necessary [needs f'ed up commits]

29b7c5d

nr2.0: Start using newtype pattern for Usage and Declaration

f49671c

late: Setup builtin types properly, change Rib API

c04726a

typecheck path: wip

67f1b28

toplevel: Add note about resolving glob imports

df77f79

default: Visit external functions properly

230a037

add more name res test casaes

1719fb3

Change to new resolution 2.0

723cc17

Change the test's name resolution algorithm to 2.0. gcc/testsuite/ChangeLog: * rust/compile/name_resolution12.rs: Add name resolution 2.0 flag. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change to name resolution 2.0

5ba2a90

Change test name resolution algorithm to 2.0. gcc/testsuite/ChangeLog: * rust/compile/name_resolution13.rs: Add compile flag to use the new name resolution 2.0 algorithm. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

Change name resolution version in test

cae4a70

Change the name resoltion algorithm to 2.0 in this test. gcc/testsuite/ChangeLog: * rust/compile/name_resolution14.rs: Add flag to activate name resolution 2.0. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>

late: Add bool builtin type

15afef4

tests: Re-add macro nr2.0 test cases

022d75c

CohenArthur closed this Jan 6, 2025

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

Add late name resolution pass #2620

Add late name resolution pass #2620

CohenArthur commented Sep 12, 2023

matthewjasper Sep 12, 2023

matthewjasper Sep 12, 2023

matthewjasper Sep 12, 2023

matthewjasper Sep 12, 2023

dkm Sep 13, 2023

P-E-P commented Sep 19, 2023 •

edited

Loading

CohenArthur commented Sep 21, 2023

CohenArthur commented Nov 8, 2023

P-E-P commented May 29, 2024


		auto candidate = nr_ctx.values.to_rib (body_mappings.get_nodeid ());

		// FIXME: Ugly

Add late name resolution pass #2620

Add late name resolution pass #2620

Conversation

CohenArthur commented Sep 12, 2023

matthewjasper Sep 12, 2023

Choose a reason for hiding this comment

matthewjasper Sep 12, 2023

Choose a reason for hiding this comment

matthewjasper Sep 12, 2023

Choose a reason for hiding this comment

matthewjasper Sep 12, 2023

Choose a reason for hiding this comment

dkm Sep 13, 2023

Choose a reason for hiding this comment

P-E-P commented Sep 19, 2023 • edited Loading

CohenArthur commented Sep 21, 2023

CohenArthur commented Nov 8, 2023

P-E-P commented May 29, 2024

P-E-P commented Sep 19, 2023 •

edited

Loading