Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix overridden virtual method modifier #2707

Merged
merged 1 commit into from
Oct 24, 2023
Merged

Fix overridden virtual method modifier #2707

merged 1 commit into from
Oct 24, 2023

Conversation

P-E-P
Copy link
Member

@P-E-P P-E-P commented Oct 23, 2023

Overridden virtual methods were not marked as such.

@P-E-P
Fix warning with overridden virtual methods
17539b1 
Overridden virtual methods were not marked as such.

gcc/rust/ChangeLog:

	* ast/rust-pattern.h: Add override modifier to overriding methods.

Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
@P-E-P P-E-P added the cleanup label Oct 23, 2023
@P-E-P P-E-P added this to the GCC 14.1 release milestone Oct 23, 2023
@P-E-P P-E-P self-assigned this Oct 23, 2023
@P-E-P P-E-P marked this pull request as ready for review October 23, 2023 14:12
@P-E-P P-E-P added this pull request to the merge queue Oct 24, 2023
Merged via the queue into Rust-GCC:master with commit 9a8b3ea Oct 24, 2023
9 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@dkm dkm dkm approved these changes

Assignees

@P-E-P P-E-P

Labels
cleanup
Projects
Project Pineapple
Status: Done
Milestone
GCC 14.1 release
Development

Successfully merging this pull request may close these issues.
2 participants
@P-E-P @dkm