Parse const with no value #2708
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Const with no value expression may exist either in trait or in disabled blocks. This means we should be able to parse those correctly. gcc/rust/ChangeLog: * ast/rust-item.h: Add a new constructor for const with no value expression. * parse/rust-parse-impl.h (Parser::parse_const_item): Allow const with no expression value. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
Highlight issue 2665's fix for const with no value expression. gcc/testsuite/ChangeLog: * rust/compile/issue-2665.rs: New test. Signed-off-by: Pierre-Emmanuel Patry <pierre-emmanuel.patry@embecosm.com>
CohenArthur
approved these changes
Oct 23, 2023
Comment on lines
+4786
to
+4794
| // A const with no given expression value | ||
| if (lexer.peek_token ()->get_id () == SEMICOLON) | ||
| { | ||
| lexer.skip_token (); | ||
| return std::unique_ptr<AST::ConstantItem> ( | ||
| new AST::ConstantItem (std::move (ident), std::move (vis), | ||
| std::move (type), std::move (outer_attrs), | ||
| locus)); | ||
| } |
There was a problem hiding this comment.
I think this is good, but we need to handle it somewhere else, right? e.g. the rest of the AST and HIR are probably expecting that an impl's const always has a value, right?
There was a problem hiding this comment.
yeah, this ICEs:
struct S;
impl S {
const D: u8;
}while it should produce a nice error: https://play.rust-lang.org/?version=stable&mode=debug&edition=2021&gist=9b8643a863d5350e8b226e8bc9789b88
this should be adressed in a later PR however :)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #2665.