-
Notifications
You must be signed in to change notification settings - Fork 163
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[WIP] Turn Name Resolution 2.0 on by default #2875
base: master
Are you sure you want to change the base?
Conversation
7612f78
to
3402b08
Compare
Is this a follow up to #2796 ? |
Not necessarily, this is just enough to get tests passing for name resolution 2.0 (although GCC 4.8 is still having problems) |
Note that this only touches early resolution |
@powerboat9 should this be a draft or is it ready for reviews? |
draft, sorry |
@powerboat9 now that @P-E-P merged his work on glob imports I think this would be a nice thing to focus on - let me know how I can help and if you'd like me to review parts of the PR or work on some stuff |
a999b59
to
a373b8e
Compare
A lot of this would now be duplicated work, but I've rebased and will start breaking this down into smaller PRs |
Forgive me but whats the purpose of this PR at the moment? |
This was an old branch I was using to work on nr2.0 -- I'll close it once I separate out the useful changes into new PRs |
09e6684
to
ed430a9
Compare
gcc/rust/ChangeLog: * resolve/rust-early-name-resolver-2.0.cc (Early::visit): Resolve the pending eager invocations inside builtin macro invocations. gcc/testsuite/ChangeLog: * rust/compile/nr2/exclude: Remove entries. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
gcc/rust/ChangeLog: * ast/rust-ast-collector.cc (TokenCollector::visit): Remove visitor for NamedFunctionParam. * ast/rust-ast-collector.h (TokenCollector::visit): Likewise. * ast/rust-ast-full-decls.h (class NamedFunctionParam): Remove forward declaration. * ast/rust-ast-visitor.cc (DefaultASTVisitor::visit): Remove visitor for NamedFunctionParam. * ast/rust-ast-visitor.h (DefaultASTVisitor::visit): Likewise. * ast/rust-ast.cc (NamedFunctionParam::as_string): Remove. * ast/rust-item.h (class NamedFunctionParam): Remove. (class ExternalFunctionItem): Remove. * parse/rust-parse-impl.h (Parser::parse_named_function_param): Remove. (Parser::parse_named_function_params): Remove. * parse/rust-parse.h (Parser::parse_named_function_param): Remove. (Parser::parse_named_function_params): Remove. Signed-off-by: Owen Avery <powerboat9.gamer@gmail.com>
I've managed to get all of the tests passing, although I had to modify a few tests. I should be able to pull out some of the more minor changes into separate pull requests